No v2 here, officer.

https://youtu.be/8Kov-gzuhDc?t=41s

ebin

Carl v2

Thank You

finally some good fucking food

congrats light!

Thanks!

smh

I can fucking watch this after all these years. My momma always said I'm "special" but I knew a DEFINITIVE edition was eventually coming along. I prayed to the right gods if this somehow got unstalled and finished. BASED!

Holy mother of based

based

It's time.

yuru camp time!

They said it couldn't be done. But it's finally here.

Thanks

Thanks!

holy shit it's actually done lmao

Thanks

The [GitHub repository](https://github.com/Kaleido-subs/Joshiraku) has now been made public. I really gotta stop forgetting to do that.

You included a version of GG (Farfie) subs that have broken TS scaling from resampling? Didn't check all TS but noticed this at first glance of episode 12 on the chapter mark.  Also your TS (Kaleido-subs track) sometimes has some blending issues bleeding through.  There's even TS text that completely disappeared in your release's GG track. (Living under the white ``block``?)  Though I did notice 1 GG sign had slightly improved background color blending in your version, a couple GG TS signs had their font changed for the better, and some blur improvements, so.. I don't know. More QC needed I guess for v3? I don't remember where I got this or if I fixed some problems myself, but here are GG (Farfie) subs that don't have TS scaling problems or missing text. Subs will need to be retimed ~24 frames on some episodes (-1000ms) since this encode was trimmed. track03 has original dialogue styling, track04 has changed styling and some different TS adjustments in some eps. I think I preferred the first track overall. Should probably only use this as a reference to compare TS and see what broke in yours, as many of your fixes are far better and the improved version I would recommend watching with. Just some TS broke that needs fixing. https://www.mediafire.com/file/uyuqb76hqxfpxln/Joshiraku_GG_%2528Farfie%2529_Subs.zip/file https://mega.nz/file/lfQQzTCJ#nQlvScvgh5bflsP3WFNcqSIS8pxU3Hp_Mqn4W-6peDM https://anonfiles.com/27Ebf62by3/Joshiraku_GG_Farfie_Subs_zip Some TS looks better with a font in these subs than yours too. 

I also happened to noticed GG dialogue starting some frames (2 frames earlier in this case) before it is spoken in your release too.  Some chapters are slightly off too, for example ep 10 has a 2 second chapter at the beginning. > Features an alt track using slightly (very slightly) cleaned up gg subs (through Farfie). We recommend our subs over them, but included them because they still feature a lot of interesting translation choices that I feel anyone can appreciate. If you want to watch them, I’d suggest doing so during a rewatch! I as well agree with this if anyone's reading my quick comment QC as complaining. I just think including a cleaned up alt track shouldn't necessarily mean leaving it more broken in some places than how it came.

Also GG sign colors are different in your included subs. No longer color matched to the video in various TS places. Darker from color matrix change in .ass from TV.601 to TV.709 without correcting TS assigned color values? Top Kaleido-GG (Farfie), bottom track03-GG (Farfie). 

Thanks for the report, but next time, please drop these in our public_qc channel on Discord or leave them in an issue on GitHub. Way easier to follow! gg's subs are mostly added as an extra and not QC'd. Colours differ because the Farfie release (which these were indeed sourced from) had them tagged in the wrong colourspace, presumably from gg's release itself. Timing is also not going to be perfect because gg used a TV encode I believe and I'm not sure if Farfie fixed them (and our timer thought adding the subs was a waste of time so didn't want to retime), so scene changes will slightly differ. That said, the one issue that surprises me is the font one. I'm not getting any missing font errors, so not sure how that happened. Either way, I don't plan on doing many fixes for the gg subs, but the more easier ones should be fixable for the eventual v3, especially using those subs you posted as additional reference. Please do leave an issue on GitHub with checkboxes, as it makes it way easier to keep track! :)

Thanks Light! Finally watching this show, better be good xD

but there's still timing issues on your subs

> please drop these in our public_qc channel on Discord or leave them in an issue on GitHub Sure, I can do that next time I suppose. > tagged in the wrong colourspace If you mean for BD releases, sure. But the clamped color space was generally fine for most signs except ones that used larger background blending (most of the time anyways, it's not perfect on some signs even now). Intentionally changing it to 709 without correcting all the TS with color values usually breaks or leaves it worse more often than not. > Timing is also not going to be perfect because gg used a TV encode I believe and I’m not sure if Farfie fixed them The subs I linked above don't have that issue with just a simple -1000ms offset for episodes that were trimmed (all but 1?). So your timer must have adjusted it without checking. > Please do leave an issue on GitHub with checkboxes, as it makes it way easier to keep track! 👍

@Mabby Not that I have a horse in this race, but changing the color matrix of subs in Aegisub is supposed to change their colors to match. If I resample the colors of any random script that I have around right now the results look the same. What player/renderer are you using?

@REFERENCE_HERE I'm using mpv, latest upstream commit as of today. > changing the color matrix of subs in Aegisub is supposed to change their colors to match. Checking the .ass, the color values on the TS were not changed comparing Kaleido GG TV.709 to the GG TV.601 I have. So if it is suppose to adjust the TS, then the version used didn't do so or they just manually renamed the matrix in each file. Or the TS styling is done in an odd way that Aegisub didn't pick it up for adjustment. A handful of signs across all episodes have (slightly) different colors now because of the wider gamut. Since the same color values in a wider matrix will have different colors displayed, the TS would need to be adjusted and matched back to what was originally intended. Kaleido GG - YCbCr Matrix: TV.709 ``` Dialogue: 1,0:07:53.91,0:07:57.16,block,,0,0,0,,{\pos(928.8,649.8)\fnArial Narrow\b1\c&H7655BC&\be2}U e n o {Zoo} Dialogue: 0,0:07:53.91,0:07:57.16,block,,0,0,0,,{\pos(928.8,649.8)\fnArial Narrow\b1\bord3\c&H7655BC&\3c&HF1F6DB&\be2}U e n o {Zoo} ``` GG (Farfie) - YCbCr Matrix: TV.601 ``` Dialogue: 1,0:07:54.91,0:07:58.16,block,,0,0,0,,{\be1\fnArial Narrow\bord0\shad0\b1\c&H7655BC&\pos(619.2,433.2)}U e n o {Zoo} Dialogue: 0,0:07:54.91,0:07:58.16,block,,0,0,0,,{\be1\fnArial Narrow\bord2\shad0\b1\c&H7655BC&\3c&HF1F6DB&\pos(619.2,433.2)}U e n o {Zoo} ``` Matching the color space to the video encode _is_ generally good. Especially if blending subtitles into the video stream. Just this unnaturally breaks some older signs since it wasn't adjusted for the wider range, hence needing to adjust. Some signs were color matched and no longer are. You _can_ have subtitles in a clamped matrix on a wider video gamut, just then some background blending may not match if it was intended for a clamped video. With how minimal the wider gamut changes in certain colors from 601 to 709, you can get an idea how certain colors may look fine & unchanged while others now don't. 

Oh, OK. that explains it.

Moral of the story is colourspaces suck

Thanks!